Re: [pve-devel] [PATCH manager 6/7] report: add info about (un)used memory slots

[Alexander Zeidler <a.zeidler@proxmox.com>]

On Thu, 2024-04-18 at 12:20 +0200, Mira Limbeck wrote:
> On 4/18/24 11:16, Alexander Zeidler wrote:
> > * to see if a RAM upgrade is slot/capacity-wise possible
> > * to spot added/replaced RAM that may now be causing issues
> > 
> > 	Maximum Capacity: 2 TB
> > 	Size: 16 GB	Part Number: 18ASF2G72PZ-2G6D1
> > 	Size: 16 GB	Part Number: 18ASF2G72PZ-2G6D1
> > 	Size: 16 GB	Part Number: 18ASF2G72PZ-2G6D1
> > 	Size: 16 GB	Part Number: 18ASF2G72PZ-2G6D1
> > 	Size: No Module Installed
> > 	Size: No Module Installed
> > 	Size: No Module Installed
> > 	Size: No Module Installed
> > 
> > Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>

> >  		'dmidecode -t 0,3,32',
> > +		'dmidecode -t16,17 | grep -P "^\t(Max[^:]*city|Size|Part)" | sed -Ez "s/\n(\tP[^\n]*)/\1/g" | sort',
> Please add a space between `-t` and `16,17`.
Ok

> >  		'lspci -nnk',
> >  	    ],
> >  	},
> 
> To be honest, I'm not a fan of this command.
I see.


> In those few cases it was
> interesting to see, we often wanted to see all the information. And the
> full dmidecode -t 17 output is just too much for the report.
I agree that the full output is neither often needed nor suitable for the
system report. Therefore printing only some information, which can be even
more compact as shown here:
https://lists.proxmox.com/pipermail/pve-devel/2024-April/063313.html


> Not to mention the quite complicated `grep | sed | sort` part that might
> break on some systems that report things differently.
Hm, from a technical point of view this should still be okay? At least
grep and sed is also useful for such (trivial) cases.

If it breaks in the future, we should be able to fix it. If we have never
used it by then, we can also remove it.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel