From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager v2 1/2] ui: cloudinit: use cloudinit update api when regenerating images
Date: Sun, 10 Nov 2024 19:59:59 +0100 [thread overview]
Message-ID: <639e1349-5fb2-4c6d-adaf-fb5c67031a86@proxmox.com> (raw)
In-Reply-To: <20241107144055.202870-1-d.kral@proxmox.com>
Am 07.11.24 um 15:40 schrieb Daniel Kral:
> Changes the behavior of the "Regenerate Image" button in the VM's
> CloudInit tab from using the more expensive VM update API endpoint to
> using the CloudInit update API endpoint.
>
> Originally-by: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> Changes since v1 (as suggested by @Fiona):
> - added this patch to reduce the needed permissions
> - added a commit message to the applied patch
> - no changes to the original patch hunk
>
> This change has been taken from a previously unapplied commit [0]. I
> have only applied the changes done to the button handler.
>
> The rest of the original patch also touches the functionality of editing
> the fields, which breaks the check if a cloudinit disk is present,
> because the cloudinit_pending's response no longer includes the
> CloudInit disk drive property itself and therefore will always show "No
> CloudInit drive found". This change could be included in the future, but
> is not part of my original patch's intention.
>
> www/manager6/qemu/CloudInit.js | 32 +++++---------------------------
> 1 file changed, 5 insertions(+), 27 deletions(-)
>
>
applied both patches, thanks! FWIW, I made a small follow-up to go for a shorter
"show alert on failure" callback, as this file still used the older style from
before the time we could use arrow-fns.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-10 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 14:40 [pve-devel] " Daniel Kral
2024-11-07 14:40 ` [pve-devel] [PATCH manager v2 2/2] ui: cloudinit: disallow unprivileged users to regenerate images Daniel Kral
2024-11-10 18:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=639e1349-5fb2-4c6d-adaf-fb5c67031a86@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox