public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer v2] gui: always set visible-child-name on disk dialog
Date: Fri, 4 Apr 2025 10:59:13 +0200	[thread overview]
Message-ID: <635a9aa3-fbd9-43c9-a384-143ff23e6384@proxmox.com> (raw)
In-Reply-To: <20250404083957.107263-1-m.sandoval@proxmox.com>

Am 04.04.25 um 10:39 schrieb Maximiliano Sandoval:
> We show the size selection stack page whenever a filesystem is selected
> in the dropdown.
> 
> At the moment when one selects certain raid setups (e.g. btrfs RAID10),
> then enters the Advanced Options page and then selects certain non-raid
> setups (e.g ext4), the `raiddisk` page will still be visible since the
> visible-child (and visible-child-name) property still points to it.
> 
> Reported-by: Alexander Zeidler <a.zeidler@proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> 
> Differences from v1:
>  - Improve commit message
>  - Describe better the reproducer in the commit
> 
>  proxinstall | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-04-04  9:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04  8:39 [pve-devel] " Maximiliano Sandoval
2025-04-04  8:59 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=635a9aa3-fbd9-43c9-a384-143ff23e6384@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal