From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Max Carrara <m.carrara@proxmox.com>
Subject: [pve-devel] applied: [PATCH v3 manager 3/3] ui: cert upload: fix private key field sending empty string
Date: Tue, 21 Mar 2023 16:57:05 +0100 [thread overview]
Message-ID: <62a0a884-d765-683d-745a-92ca74defd15@proxmox.com> (raw)
In-Reply-To: <20230314150839.248059-4-m.carrara@proxmox.com>
Am 14/03/2023 um 16:08 schrieb Max Carrara:
> The private key's field is now excluded from the upload form's
> JSON data if it's left empty.
>
> Prior to this change, the form still used an empty string for the
> private key's field, even if no key was provided by the user.
> Because the key's field is marked as optional in the upload cert
> API endpoint, JSONSchema validation would therefore fail.
>
> Signed-off-by: Max Carrara <m.carrara@proxmox.com>
> ---
> www/manager6/node/Certificates.js | 3 +++
> 1 file changed, 3 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2023-03-21 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 15:08 [pve-devel] [PATCH v3 manager 0/3] Fix SSL Certificate and Key Upload Issues Max Carrara
2023-03-14 15:08 ` [pve-devel] [PATCH v3 manager 1/3] fix #4552: certhelpers: check if custom cert and key match on change Max Carrara
2023-03-22 15:41 ` Max Carrara
2023-03-23 6:08 ` Thomas Lamprecht
2023-03-14 15:08 ` [pve-devel] [PATCH v3 manager 2/3] ui: cert upload: use inputpanel for certificate upload Max Carrara
2023-03-21 15:56 ` [pve-devel] applied: " Thomas Lamprecht
2023-03-14 15:08 ` [pve-devel] [PATCH v3 manager 3/3] ui: cert upload: fix private key field sending empty string Max Carrara
2023-03-21 15:57 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62a0a884-d765-683d-745a-92ca74defd15@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.carrara@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox