From: "Michael Köppl" <m.koeppl@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
Subject: Re: [pve-devel] [PATCH container v5 2/4] lxc: get volid through parse_volume()
Date: Tue, 20 May 2025 11:12:04 +0200 [thread overview]
Message-ID: <6265a8d5-b021-48de-b107-b76dfccec6ae@proxmox.com> (raw)
In-Reply-To: <fb2542a5-939e-4db7-bc41-52921d91bf3b@proxmox.com>
On 5/19/25 10:09, Thomas Lamprecht wrote:
> Am 19.05.25 um 09:50 schrieb Michael Köppl:
>> Thanks for the hint! It seems I have missed that option, wasn't sure how
>> to handle it otherwise. Will use it in the future. If a v6 of this
>> series becomes necessary, I'll add Stefan's former email address again.
>
> Please send a v6 in any case with the trailers being complete even if
> nothing else comes up over a day or so. That way it's easier to avoid that
> something bogus will be pushed out. We currently have no automation to
> check these things, and they can be somewhat easy to overlook. And it's
> always great if one can avoid that maintainers need to do extra work on
> applying/pushing things, as often their plate is rather full as is already.
Ack, sent out a v6:
https://lore.proxmox.com/pve-devel/20250520090818.44881-1-m.koeppl@proxmox.com/T/#
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-05-20 9:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 8:03 [pve-devel] [PATCH container/qemu-server v5 0/7] fix #3711 and adapt drive detach/remove behavior Michael Köppl
2025-05-13 8:03 ` [pve-devel] [PATCH container v5 1/4] fix #3711: lxc: print warning if storage for mounted volume does not exist anymore Michael Köppl
2025-05-13 8:03 ` [pve-devel] [PATCH container v5 2/4] lxc: get volid through parse_volume() Michael Köppl
2025-05-13 13:37 ` Daniel Kral
2025-05-13 13:48 ` Daniel Kral
2025-05-14 14:18 ` Thomas Lamprecht
2025-05-19 7:50 ` Michael Köppl
2025-05-19 8:09 ` Thomas Lamprecht
2025-05-20 9:12 ` Michael Köppl [this message]
2025-05-13 8:03 ` [pve-devel] [PATCH container v5 3/4] fix #3711: lxc: allow removing unused mp if storage no longer exists Michael Köppl
2025-05-13 8:03 ` [pve-devel] [PATCH container v5 4/4] add linked clone check when destroying container Michael Köppl
2025-05-13 8:03 ` [pve-devel] [PATCH qemu-server v5 1/3] adapt linked clone check to not die if an error occurs during check Michael Köppl
2025-05-13 8:03 ` [pve-devel] [PATCH qemu-server v5 2/3] print warning for PVE::Storage::path errors instead of failing Michael Köppl
2025-05-13 8:03 ` [pve-devel] [PATCH qemu-server v5 3/3] mark volumes pending detach as unused if storage was removed Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6265a8d5-b021-48de-b107-b76dfccec6ae@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox