From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer 2/2] common: pinning: use pve-iface regular expression for validation
Date: Mon, 1 Dec 2025 11:53:53 +0100 [thread overview]
Message-ID: <623c44ed-bbad-4c3a-b5c1-66f5a47f8d5c@proxmox.com> (raw)
In-Reply-To: <20251126180819.817240-3-s.ivanov@proxmox.com>
Am 26.11.25 um 7:08 PM schrieb Stoiko Ivanov:
> + static RE: OnceLock<Regex> = OnceLock::new();
> + let re = RE.get_or_init(|| {
> + RegexBuilder::new(r"^[a-z][a-z0-9_]{1,20}([:\.]\d+)?$")
Should the later part with a colon really be allowed? On the new test
ISO, a name like 'nicat:3' will be accepted, but won't actually work
later when booting:
"Interface name is not valid or too long, ignoring assignment: nicat:3"
I guess the dot can make sense if there are multiple NICs, so you could
have e.g. 'nic0' and 'nic0.3'?
> + .case_insensitive(true)
> + .build()
> + .unwrap()
> + });
> +
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-12-01 10:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-26 18:07 [pve-devel] [PATCH installer 0/2] sync allowed nic-names with pve-common by using the same regex Stoiko Ivanov
2025-11-26 18:07 ` [pve-devel] [PATCH installer 1/2] sys: net: use literal pve-iface regular expression for validation Stoiko Ivanov
2025-11-26 18:07 ` [pve-devel] [PATCH installer 2/2] common: pinning: use " Stoiko Ivanov
2025-12-01 10:53 ` Fiona Ebner [this message]
2025-12-01 11:46 ` Stoiko Ivanov
2025-11-27 7:18 ` [pve-devel] applied: [PATCH installer 0/2] sync allowed nic-names with pve-common by using the same regex Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=623c44ed-bbad-4c3a-b5c1-66f5a47f8d5c@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox