From: Stefan Sterz <s.sterz@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v2 4/4] parse vm config: remove "\s*" from multi-line comment regex
Date: Fri, 25 Feb 2022 09:26:41 +0100 [thread overview]
Message-ID: <6236827c-0bcc-abee-791d-1dda43dfefed@proxmox.com> (raw)
In-Reply-To: <433512123.3099.1645720104625@webmail.proxmox.com>
On 24.02.22 17:28, Dietmar Maurer wrote:
>
>> On 02/24/2022 3:49 PM Stefan Sterz <s.sterz@proxmox.com> wrote:
>>
>>
>> To be consistent with PBS's implementation of multi-line comments
>> remove "\s*" here too. Since the regex isn't lazy .* matches
>> everything \s* would anyway.
>
> But the old regex trimm spaces from the end, so this is quite different!
It would if the ".*" was evaluated lazily (as in ".*?"), but from my
testing it isn't. So since ".*" matches spaces greedily, they are
actually not trimmed. The only character that is matched by "\s" and
not by "." are line breaks, but those occur after the "$".
Hence, "\s" should never match anything here. I've also discussed this
with Wolfgang Bumiller off list.
next prev parent reply other threads:[~2022-02-25 8:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 16:28 Dietmar Maurer
2022-02-25 8:26 ` Stefan Sterz [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-02-24 14:49 Stefan Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6236827c-0bcc-abee-791d-1dda43dfefed@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox