Re: [pve-devel] [PATCH common] tools: file_set_contents: use syswrite instead of print

From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH common] tools: file_set_contents: use syswrite instead of print
Date: Wed, 25 Sep 2024 10:39:54 +0200 (CEST)	[thread overview]
Message-ID: <623295300.4070.1727253594226@webmail.proxmox.com> (raw)
In-Reply-To: <20240924143321.93696-1-f.schauer@proxmox.com>

Please can you add the column showing write amplification using dd instead of file_set_contents, so that we can also see the minimal write amplf. from sqlite.

> The table below illustrates the drastic reduction in write
> amplification when writing files of different sizes to `/etc/pve/` using
> `file_set_contents`:
> 
>            print                big_writes+print     big_writes+syswrite
> data size  written     amplif.  written     amplif.  written    amplif.
>     1 KiB      48 KiB     48.0      45 KiB     45.0     41 KiB     41.0
>     2 KiB      48 KiB     24.0      45 KiB     22.5     62 KiB     31.0
>     4 KiB      82 KiB     20.5      80 KiB     20.0     73 KiB     18.3
>     8 KiB     121 KiB     15.1      90 KiB     11.3     89 KiB     11.1
>    16 KiB     217 KiB     13.6     146 KiB      9.1    113 KiB      7.1
>    32 KiB     506 KiB     15.8     314 KiB      9.8    158 KiB      4.9
>    64 KiB    1472 KiB     23.0     826 KiB     12.9    259 KiB      4.0
>   128 KiB    5585 KiB     43.6    3765 KiB     29.4    452 KiB      3.5
>   256 KiB   20424 KiB     79.8   10743 KiB     42.0   2351 KiB      9.2
>   512 KiB   86715 KiB    169.4   43650 KiB     85.3   3204 KiB      6.3
>  1024 KiB  369568 KiB    360.9  187496 KiB    183.1  15845 KiB     15.5
>

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel