public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox-i18n] js generator: try to extract comments from source
Date: Wed, 30 Aug 2023 17:11:46 +0200	[thread overview]
Message-ID: <621447e8-f4a6-4e0a-8725-b8583b33b7f7@proxmox.com> (raw)
In-Reply-To: <a6181732-29e3-4daf-b157-05d86b105a02@proxmox.com>


On 8/30/23 15:23, Thomas Lamprecht wrote:
> Oh, and while at it, I pondered over adding a wrapper for the common Ext.String.format(gettext(MSG), PARAMS)) combi, something like gettextf(MSG, PARAMS) or even shorter i18n(MSG, PARAMS) (with params optional). This way we might even parse the passed params and add those as comment automatically.


Regarding this, sounds like a good idea for a future patch.





      parent reply	other threads:[~2023-08-30 15:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 12:48 Maximiliano Sandoval
2023-08-30 13:23 ` Thomas Lamprecht
2023-08-30 13:49   ` Maximiliano Sandoval
2023-08-30 15:11   ` Maximiliano Sandoval [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=621447e8-f4a6-4e0a-8725-b8583b33b7f7@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal