From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: PVE development discussion <pve-devel@pve.proxmox.com>,
Mira Limbeck <m.limbeck@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 firewall] introduce new icmp-type parameter
Date: Wed, 9 Sep 2020 20:56:48 +0200 [thread overview]
Message-ID: <61d8ed34-7ea5-9e70-70ee-5c796d4dd82b@proxmox.com> (raw)
In-Reply-To: <20200529122206.31787-1-m.limbeck@proxmox.com>
On 29.05.20 14:22, Mira Limbeck wrote:
> Currently icmp types are handled via 'dport'. This is not documented
> anywhere except for a single line of comment in the code. To untangle
> the icmp-type handling from the dport handling a new 'icmp-type'
> parameter is introduced.
>
> The valid 'icmp-type' values are limited to the names
> (icmp[v6]_type_names hash in the code, same as ip[6]tables provides).
> Type[/Code] values are not supported.
>
> Support for ipv6-icmp is added to icmp-type parameter handling. This makes it
> possible to specify icmpv6 types via the GUI.
>
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> v2:
> - rebased on master
> - removed type[/code] value support, now only names are accepted
>
> src/PVE/API2/Firewall/Rules.pm | 4 +++
> src/PVE/Firewall.pm | 50 +++++++++++++++++++++++++++++++++-
> 2 files changed, 53 insertions(+), 1 deletion(-)
>
>
applied, thanks!
next parent reply other threads:[~2020-09-09 18:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200529122206.31787-1-m.limbeck@proxmox.com>
2020-09-09 18:56 ` Thomas Lamprecht [this message]
[not found] ` <20200529122206.31787-2-m.limbeck@proxmox.com>
2022-03-16 14:23 ` [pve-devel] applied: [PATCH v2 docs] add documentation for the " Thomas Lamprecht
[not found] ` <20200529122206.31787-3-m.limbeck@proxmox.com>
2022-03-16 14:23 ` [pve-devel] applied: [PATCH manager v2] change icmp type selector to a combogrid Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61d8ed34-7ea5-9e70-70ee-5c796d4dd82b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.limbeck@proxmox.com \
--cc=pve-devel@pve.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox