From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Matthias Heiserer <m.heiserer@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 2/2] GUI: efi disk: cleanup - var to const
Date: Fri, 20 Jan 2023 14:59:37 +0100 [thread overview]
Message-ID: <61be8a8c-7c0e-9f6a-773c-27ff1702489c@proxmox.com> (raw)
In-Reply-To: <a1b5707e-8260-d23e-38b2-5cc4c752aac1@proxmox.com>
Am 20/01/2023 um 12:16 schrieb Matthias Heiserer:
>>
>> I'm not that huge fan of applying JavaScript's const broadly to non-scalar values,
>> as it's only a shallow constant and immutable; so no effect on array/object member.
>
> I quite like const, especially with `const me = this`, because it tells me that I don't have to worry about the variable being reassigned.
> But as long as there's a guideline on whether to use it, I'm happy 😄
Yeah for the `me` (component) this alias it could have some merit;
albeit I'm don't think this was ever an issue in the committed code,
neither during development, but for the latter I naturally can only
speak for myself.
next prev parent reply other threads:[~2023-01-20 14:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-17 12:17 [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64 Matthias Heiserer
2023-01-17 12:17 ` [pve-devel] [PATCH manager 2/2] GUI: efi disk: cleanup - var to const Matthias Heiserer
2023-01-18 14:03 ` Thomas Lamprecht
2023-01-20 11:16 ` Matthias Heiserer
2023-01-20 13:59 ` Thomas Lamprecht [this message]
2023-01-18 14:07 ` [pve-devel] [PATCH manager 1/2] GUI: efi disk: use correct version with aarch64 Thomas Lamprecht
2023-01-20 12:56 ` Matthias Heiserer
2023-01-20 13:17 ` Thomas Lamprecht
2023-01-20 14:18 ` Matthias Heiserer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61be8a8c-7c0e-9f6a-773c-27ff1702489c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox