public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Mira Limbeck <m.limbeck@proxmox.com>
Subject: [pve-devel] applied: [PATCH firewall] fix #2358: allow --<opt> in firewall rule config files
Date: Mon, 22 Feb 2021 14:43:10 +0100	[thread overview]
Message-ID: <61a8b444-c10e-80db-672c-5267a63ecba2@proxmox.com> (raw)
In-Reply-To: <20210222120018.14608-1-m.limbeck@proxmox.com>

On 22.02.21 13:00, Mira Limbeck wrote:
> The docs mention --<opt> as valid syntax for firewall rules, but the
> code that parses the .fw files only accepts -<opt>. To make it
> consistent with the docs and the API, also accept --<opt>.
> 
> In addition allow 'proto' as option, not only '-p'.
> 
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
>  src/PVE/Firewall.pm | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
>

applied, thanks!




      reply	other threads:[~2021-02-22 13:43 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 12:00 [pve-devel] " Mira Limbeck
2021-02-22 13:43 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61a8b444-c10e-80db-672c-5267a63ecba2@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=m.limbeck@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal