From: Dominik Csapak <d.csapak@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH docs] passthrough: viommu: remove 'amd_iommu=on' from the docs
Date: Wed, 24 Jul 2024 12:16:44 +0200 [thread overview]
Message-ID: <6052ced1-5755-4231-b102-8bb6fa097dae@proxmox.com> (raw)
In-Reply-To: <7b89263e-0efa-44fc-b5d4-8acea3684540@proxmox.com>
On 7/24/24 11:59, Fiona Ebner wrote:
> Am 26.04.24 um 09:58 schrieb Dominik Csapak:
>> this is wrong and does nothing, see previous commit:
>> 0c54d61 (remove 'amd_iommu=on' from the passthrough docs)
>> and
>> https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html?highlight=amd_iommu
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> qm-pci-passthrough.adoc | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/qm-pci-passthrough.adoc b/qm-pci-passthrough.adoc
>> index bbd6b85..14f7fa5 100644
>> --- a/qm-pci-passthrough.adoc
>> +++ b/qm-pci-passthrough.adoc
>> @@ -511,8 +511,7 @@ There are currently two vIOMMU implementations available: Intel and VirtIO.
>>
>> Host requirement:
>>
>> -* Add `intel_iommu=on` or `amd_iommu=on` depending on your CPU to your kernel
>> -command line.
>> +* Add `intel_iommu=on` depending on your CPU to your kernel command line.
>>
>
> IMHO saying "For Intel CPUs, add ..." sounds nicer than "add ...
> depending on your CPU" together with your change. And we could also
> mention that it's only required for kernels before 6.8 and nothing for
> AMD CPUs?
Makes sense, but i'd probably leave the kernel version part out,
since that changed in the kernel a few times already (and activating it
if it's default shouldn't hurt much)
Long term i'd like to make that a gui feature anyway where
we automatically do the right thing
>
>> Intel vIOMMU
>> ^^^^^^^^^^^^
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-07-24 10:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 7:58 Dominik Csapak
2024-07-24 9:59 ` Fiona Ebner
2024-07-24 10:16 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6052ced1-5755-4231-b102-8bb6fa097dae@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox