[pve-devel] [PATCH manager] ui: fix Guest Summary Notes height

[pve-devel] [PATCH manager] ui: fix Guest Summary Notes height

[Dominik Csapak]

fixes 'infinite' height of the guest notes, by setting the height on the
container a level up

the notes view itself is already scrollable, so if it is too large,
there'll be a scrollbar

this does not change anything for templates, as there we show nothing
under the notes and thus there the infinite height is ok

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
should apply to stable-6 too if we want that
 www/manager6/panel/GuestStatusView.js | 2 --
 www/manager6/panel/GuestSummary.js    | 1 +
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js
index 5929d9bf..8db1f492 100644
--- a/www/manager6/panel/GuestStatusView.js
+++ b/www/manager6/panel/GuestStatusView.js
@@ -3,8 +3,6 @@ Ext.define('PVE.panel.GuestStatusView', {
     alias: 'widget.pveGuestStatusView',
     mixins: ['Proxmox.Mixin.CBind'],
 
-    height: 300,
-
     cbindData: function(initialConfig) {
 	var me = this;
 	return {
diff --git a/www/manager6/panel/GuestSummary.js b/www/manager6/panel/GuestSummary.js
index 7061b1a4..82cc7a7f 100644
--- a/www/manager6/panel/GuestSummary.js
+++ b/www/manager6/panel/GuestSummary.js
@@ -54,6 +54,7 @@ Ext.define('PVE.qemu.Summary', {
 	    items = [
 		{
 		    xtype: 'container',
+		    height: 300,
 		    layout: {
 			type: 'hbox',
 			align: 'stretch',
-- 
2.20.1

[pve-devel] applied: [PATCH manager] ui: fix Guest Summary Notes height

[Thomas Lamprecht]

On 18.06.21 13:34, Dominik Csapak wrote:
> fixes 'infinite' height of the guest notes, by setting the height on the
> container a level up
> 
> the notes view itself is already scrollable, so if it is too large,
> there'll be a scrollbar
> 
> this does not change anything for templates, as there we show nothing
> under the notes and thus there the infinite height is ok
> 

did not saw any complaints there, but it's a really easy fix so I'm going to
cherry-pick it

> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> should apply to stable-6 too if we want that
>  www/manager6/panel/GuestStatusView.js | 2 --
>  www/manager6/panel/GuestSummary.js    | 1 +
>  2 files changed, 1 insertion(+), 2 deletions(-)
> 
>

wow, that was fast.

applied, thanks!