From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: fix Guest Summary Notes height
Date: Fri, 18 Jun 2021 13:38:28 +0200 [thread overview]
Message-ID: <603b714c-6b11-cf03-b6e2-b28cdaa7b1fd@proxmox.com> (raw)
In-Reply-To: <20210618113409.32548-1-d.csapak@proxmox.com>
On 18.06.21 13:34, Dominik Csapak wrote:
> fixes 'infinite' height of the guest notes, by setting the height on the
> container a level up
>
> the notes view itself is already scrollable, so if it is too large,
> there'll be a scrollbar
>
> this does not change anything for templates, as there we show nothing
> under the notes and thus there the infinite height is ok
>
did not saw any complaints there, but it's a really easy fix so I'm going to
cherry-pick it
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> should apply to stable-6 too if we want that
> www/manager6/panel/GuestStatusView.js | 2 --
> www/manager6/panel/GuestSummary.js | 1 +
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
>
wow, that was fast.
applied, thanks!
prev parent reply other threads:[~2021-06-18 11:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 11:34 [pve-devel] " Dominik Csapak
2021-06-18 11:38 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=603b714c-6b11-cf03-b6e2-b28cdaa7b1fd@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox