From: Christoph Heiss <c.heiss@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH installer] tui: Add a cancel button to Advanced bootdisk options
Date: Wed, 21 Jun 2023 12:32:54 +0200 [thread overview]
Message-ID: <5zdqw5yi2rx3rwz4frk47w4obetyl7hsrmgxp3bctnocdyhawy@dxhqowihjrdj> (raw)
In-Reply-To: <20230621091609.38721-1-m.sandoval@proxmox.com>
LGTM.
On Wed, Jun 21, 2023 at 11:16:09AM +0200, Maximiliano Sandoval wrote:
> This matches the GUI installer which counts with a close (x) button.
>
Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> proxmox-tui-installer/src/views/bootdisk.rs | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/proxmox-tui-installer/src/views/bootdisk.rs b/proxmox-tui-installer/src/views/bootdisk.rs
> index 3fdbe5b..eaf343d 100644
> --- a/proxmox-tui-installer/src/views/bootdisk.rs
> +++ b/proxmox-tui-installer/src/views/bootdisk.rs
> @@ -456,6 +456,7 @@ fn advanced_options_view(disks: &[Disk], options: Rc<RefCell<BootdiskOptions>>)
> &(*options).borrow(),
> ))
> .title("Advanced bootdisk options")
> + .dismiss_button("Cancel")
> .button("Ok", {
> let options_ref = options.clone();
> move |siv| {
> --
> 2.39.2
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
next prev parent reply other threads:[~2023-06-21 10:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 9:16 Maximiliano Sandoval
2023-06-21 10:32 ` Christoph Heiss [this message]
2023-06-21 10:40 ` Thomas Lamprecht
2023-06-21 11:21 ` Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5zdqw5yi2rx3rwz4frk47w4obetyl7hsrmgxp3bctnocdyhawy@dxhqowihjrdj \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox