Re: [pve-devel] [PATCH v2] log: add perlmod logger

[Gabriel Goller <g.goller@proxmox.com>]

>Minor nit: repo in the subject prefix is missing, also the order of patches should probably reversed.

Happens when you don't use murpp, am I right? :)

>Seems to work fine, now messages logged by proxmox-notify while being in task context show up
>in the task logs again. Only downside to this approach is that we now also log to stderr
>in regular daemon (non-task) context? I don't think this is an issue tho?

I think we nearly always call perlmod functions in tasks anyway so it
should be fine. Worst case is you get duplicated errors in the journal
(i.e. stderr routed to journal and normal journal print).

>Small (visual) improvement would be to log the severity as well, similar to the rest of the task logs.
>
>E.g.
>
>INFO: notified via ...
>ERROR: could not notify via ...
>
>At the moment the prefix is not there, which is inconsistent to the other messages in the task log.

The usual tracing output is without the colon, so "ERROR ...msg...", but
I'll see what I can do (Worst case would be another custom layer).

>Consider this:
>
>Tested-by: Lukas Wagner <l.wagner@proxmox.com>

Thanks for the review!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel