Re: [pve-devel] [PATCH widget-toolkit] window: acme account: hide e-mail field if it does not exist

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 02.10.25 um 13:25 schrieb Dominik Csapak:
> it seems that currently, the account information returned by letsencrypt
> does not include the contact anymore, so there is no 'contact' field in
> the 'account' property.
> 
> To not trip up the ui, only optionally read that out, and hide the field
> completely if it does not exist.
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> I looked in the backend, we save the 'account' object verbatim from the
> api response, and the RFC [0] says it should have a contact field, but
> it's not there in my tests with the staging + normal api, so not sure
> if this is the right fix.
> 

This is probably the result from Let's Encrypt stopping to send expiry
notification emails a few months ago, see:

https://letsencrypt.org/2025/01/22/ending-expiration-emails

As that article also talk about not wanting to handle email addresses
in general, they might just have dropped the support for real.


> 0: https://www.rfc-editor.org/rfc/rfc8555#section-9.7.1
> 
>  src/window/ACMEAccount.js | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/window/ACMEAccount.js b/src/window/ACMEAccount.js
> index 095e674..939ddf2 100644
> --- a/src/window/ACMEAccount.js
> +++ b/src/window/ACMEAccount.js
> @@ -191,10 +191,11 @@ Ext.define('Proxmox.window.ACMEAccountView', {
>          me.load({
>              success: function (response) {
>                  var data = response.result.data;
> -                data.email = data.account.contact[0];
> +                data.email = data.account.contact?.[0];
>                  data.createdAt = data.account.createdAt;
>                  data.status = data.account.status;
>                  me.setValues(data);
> +                me.down('field[name=email]').setHidden(!data.email);
>              },
>          });
>      },



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel