Re: [PATCH proxmox-ve-rs 8/9] ve-config: frr: implement frr config generation for route maps

[Stefan Hanreich <s.hanreich@proxmox.com>]

On 3/25/26 4:02 PM, Gabriel Goller wrote:
> On 25.03.2026 10:41, Stefan Hanreich wrote:
>> Implements conversion traits for all the section config types, so they
>> can be converted into their respective FRR template counterpart.
>>
>> This module contains a helper for adding all route map entries to an
>> existing FRR configuration. It will overwrite existing route map
>> entries that have the same name AND order number. But if entries with
>> the same name, but different ordering, exist they will only be added
>> to the existing FRR configuration without dropping the other route map
>> entries.
>> This currently not relevant either way, because the initial API
>> implementation will reject creating route maps with names of route
>> maps that the stack auto-generates. In the future this behavior can
>> be used for selectively overriding / appending existing Proxmox VE
>> route maps.
>>
>> The helper also automatically orders route map entries according to
>> their ordering number. This allows for deterministic FRR configuration
>> output, which is important for tests and convenient for human
>> readability.
>>
>> Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
>> ---
>>  proxmox-ve-config/src/sdn/route_map.rs | 271 +++++++++++++++++++++++++
>>  1 file changed, 271 insertions(+)
>>
>> diff --git a/proxmox-ve-config/src/sdn/route_map.rs b/proxmox-ve-config/src/sdn/route_map.rs
>> index 3f4da56..8d8c4dc 100644
>> --- a/proxmox-ve-config/src/sdn/route_map.rs
>> +++ b/proxmox-ve-config/src/sdn/route_map.rs
> [snip]
>> +    impl Into<RouteMapMatch> for MatchAction {
>> +        fn into(self) -> RouteMapMatch {
>> +            match self {
>> +                Self::RouteType(evpn_route_type) => RouteMapMatch::RouteType(evpn_route_type),
>> +                Self::Vni(vni) => RouteMapMatch::Vni(vni),
>> +                Self::IpAddressPrefixList(prefix_list_name) => {
>> +                    RouteMapMatch::IpAddressPrefixList(prefix_list_name.into())
>> +                }
>> +                Self::Ip6AddressPrefixList(prefix_list_name) => {
>> +                    RouteMapMatch::Ip6AddressPrefixList(prefix_list_name.into())
>> +                }
>> +                Self::IpNextHopPrefixList(prefix_list_name) => {
>> +                    RouteMapMatch::IpNextHopPrefixList(prefix_list_name.into())
>> +                }
>> +                Self::Ip6NextHopPrefixList(prefix_list_name) => {
>> +                    RouteMapMatch::Ip6NextHopPrefixList(prefix_list_name.into())
>> +                }
>> +                Self::IpNextHopAddress(ipv4_addr) => RouteMapMatch::IpNextHopAddress(*ipv4_addr),
>> +                Self::Ip6NextHopAddress(ipv6_addr) => RouteMapMatch::Ip6NextHopAddress(*ipv6_addr),
>> +                Self::Metric(metric) => RouteMapMatch::Metric(metric),
>> +                Self::LocalPreference(local_preference) => {
>> +                    RouteMapMatch::LocalPreference(local_preference)
>> +                }
>> +                Self::Peer(ip_addr) => RouteMapMatch::Peer(ip_addr),
>> +                Self::Tag(tag) => RouteMapMatch::Tag(tag),
>> +            }
>> +        }
>> +    }
>> +
>> +    impl Into<RouteMapSet> for SetAction {
>> +        fn into(self) -> RouteMapSet {
>> +            match self {
>> +                Self::IpNextHopPeerAddress => RouteMapSet::IpNextHopPeerAddress,
>> +                Self::IpNextHopUnchanged => RouteMapSet::IpNextHopUnchanged,
>> +                Self::IpNextHop(ipv4_addr) => RouteMapSet::IpNextHop(*ipv4_addr),
>> +                Self::Ip6NextHopPeerAddress => RouteMapSet::Ip6NextHopPeerAddress,
>> +                Self::Ip6NextHopPreferGlobal => RouteMapSet::Ip6NextHopPreferGlobal,
>> +                Self::Ip6NextHop(ipv6_addr) => RouteMapSet::Ip6NextHop(*ipv6_addr),
>> +                Self::LocalPreference(local_preference) => {
>> +                    RouteMapSet::LocalPreference(local_preference)
>> +                }
>> +                Self::Tag(tag) => RouteMapSet::Tag(tag),
>> +                Self::Weight(weight) => RouteMapSet::Weight(weight),
>> +                Self::Metric(metric) => RouteMapSet::Metric(metric),
>> +                Self::Src(src) => RouteMapSet::Src(src),
>> +            }
>> +        }
>> +    }
>> +
>> +    impl Into<FrrRouteMap> for RouteMapEntry {
>> +        fn into(self) -> FrrRouteMap {
>> +            FrrRouteMap {
>> +                seq: self.id.order,
>> +                action: match self.action {
>> +                    RouteMapAction::Permit => proxmox_frr::ser::route_map::AccessAction::Permit,
>> +                    RouteMapAction::Deny => proxmox_frr::ser::route_map::AccessAction::Deny,
>> +                },
>> +                matches: self
>> +                    .match_actions
>> +                    .into_iter()
>> +                    .map(|match_action| match_action.into_inner().into())
>> +                    .collect(),
>> +                sets: self
>> +                    .set_actions
>> +                    .into_iter()
>> +                    .map(|set_action| set_action.into_inner().into())
>> +                    .collect(),
>> +                custom_frr_config: Default::default(),
>> +            }
>> +        }
>> +    }
> 
> These impls above could be From<>, even though we never need the other direction
> :) clippy otherwise complains.

fixed this - thanks!