From: Friedrich Weber <f.weber@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Subject: Re: [pve-devel] [PATCH http-server v2] http: support Content-Encoding=deflate
Date: Thu, 18 Apr 2024 10:43:04 +0200 [thread overview]
Message-ID: <5f511147-7dee-4f2f-be6b-e31240e70f73@proxmox.com> (raw)
In-Reply-To: <20240417113129.318431-1-m.sandoval@proxmox.com>
On 17/04/2024 13:31, Maximiliano Sandoval wrote:
> [...]
> - $headers->{'Accept-Encoding'} = 'gzip' if ($reqstate->{accept_gzip} && $self->{compression});
> + if ($self->{compression}) {
> + if ($reqstate->{accept_deflate} && $reqstate->{accept_gzip}) {
> + $headers->{'Accept-Encoding'} = 'gzip, deflate' if $reqstate->{accept_deflate};
Isn't this post-if redundant because we only enter the block if
$reqstate->{accept_deflate}?
> + } elsif ($reqstate->{accept_gzip}) {
> + $headers->{'Accept-Encoding'} = 'gzip' if $reqstate->{accept_gzip};
same here?
> + } elsif ($reqstate->{accept_deflate}) {
> + $headers->{'Accept-Encoding'} = 'deflate' if $reqstate->{accept_gzip};
> + }
Is this correct (accept_deflate in the elsif, accept_gzip in the
post-if)? Do we need a post-if here?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-18 8:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 11:31 Maximiliano Sandoval
2024-04-18 8:13 ` Folke Gleumes
2024-04-18 8:43 ` Friedrich Weber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f511147-7dee-4f2f-be6b-e31240e70f73@proxmox.com \
--to=f.weber@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox