From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 manager] ui: vm network: allow to override MTU for virtio devices
Date: Thu, 10 Feb 2022 14:55:55 +0100 [thread overview]
Message-ID: <5f3677d9-501f-bd86-4e25-6b79a94cdd75@proxmox.com> (raw)
In-Reply-To: <e6a65ae9-66a9-14fe-e9ca-c1e26543267f@proxmox.com>
On 2/10/22 14:53, Aaron Lauterer wrote:
> Looks good AFAICT and does what we want.
>
> We could improve it further by adding a small validator. Otherwise the user will only notice their error once they get the error msg from the API.
>
> A quick way that I came up with that could potentially be done better:
>
> diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
> index 1e34ad1c..2566d1a8 100644
> --- a/www/manager6/qemu/NetworkEdit.js
> +++ b/www/manager6/qemu/NetworkEdit.js
> @@ -184,6 +184,13 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
> bind: {
> disabled: '{!isVirtio}',
> },
> + validator: function(value) {
> + if (value === "" || (value > 0 && value <= 65520)) {
> + return true;
> + } else {
> + return gettext("must be between 0 and 65520");
The message here should of course read 1 instead of 0...
> + }
> + },
> allowBlank: true,
> },
> ];
next prev parent reply other threads:[~2022-02-10 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 11:28 Oguz Bektas
2022-02-10 13:53 ` Aaron Lauterer
2022-02-10 13:55 ` Aaron Lauterer [this message]
2022-02-10 14:08 ` Oguz Bektas
2022-02-10 14:14 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f3677d9-501f-bd86-4e25-6b79a94cdd75@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox