From: Stefan Sterz <s.sterz@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Tschlatscher <d.tschlatscher@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager/widget-toolkit v6] fix: #3971 Tasklog download button
Date: Wed, 4 Jan 2023 14:31:07 +0100 [thread overview]
Message-ID: <5eec06e7-2ad7-0c40-ba71-9fc2f062c9d4@proxmox.com> (raw)
In-Reply-To: <20230104125635.421634-1-d.tschlatscher@proxmox.com>
series lgtm now and seems to work as intended across pmg/pve/pbs
so consider this:
Tested-by: Stefan Sterz <s.sterz@proxmox.com>
Reviewed-by: Stefan Sterz <s.sterz@proxmox.com>
On 1/4/23 13:56, Daniel Tschlatscher wrote:
> This patch series' aim is to add a download button in the tasklog-
> viewer GUI so that users may access the tasklog more easily.
> (The tasklog-viewer only displays 50 lines at a time)
> Instead of suddenly returning a file stream when the 'limit' parameter
> is set to 0, now, a new parameter 'download' needs to be passed.
> This parameter is mutually exclusive with the other parameters.
>
> With the backend patches for pmg and pbs already being applied, these
> are the final patches to make the download work.
> Therefore, this revision only contains the missing backend patch for
> PVE and the GUI patches in the widget-toolkit for the button in the
> TaskViewer.
>
> Changes from v5:
> * The last version used parameter 'limit=0' instead of 'download=1'
> for the download URL.
> * Cleaned up one NIT in manager.
>
> Thanks to sterzy for the review!
>
> pve-manager:
>
> Daniel Tschlatscher (1):
> make task log downloadable in the PVE manager backend
>
> PVE/API2/Tasks.pm | 49 ++++++++++++++++++++++++++++++++++++++++-------
> 1 file changed, 42 insertions(+), 7 deletions(-)
>
>
> proxmox-widget-toolkit:
>
> Daniel Tschlatscher (2):
> Source file download call in central function
> add task log download button in TaskViewer
>
> src/Utils.js | 13 +++++++++++++
> src/window/FileBrowser.js | 11 +++++------
> src/window/TaskViewer.js | 17 +++++++++++++++--
> 3 files changed, 33 insertions(+), 8 deletions(-)
>
next prev parent reply other threads:[~2023-01-04 13:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 12:56 Daniel Tschlatscher
2023-01-04 12:56 ` [pve-devel] [PATCH manager v6 1/3] make task log downloadable in the PVE manager backend Daniel Tschlatscher
2023-01-04 12:56 ` [pve-devel] [PATCH widget-toolkit v6 2/3] Source file download in new Utils function Daniel Tschlatscher
2023-01-04 12:56 ` [pve-devel] [PATCH widget-toolkit v6 3/3] add task log download button in TaskViewer Daniel Tschlatscher
2023-01-04 13:31 ` Stefan Sterz [this message]
2023-01-04 13:46 ` [pve-devel] applied: [PATCH manager/widget-toolkit v6] fix: #3971 Tasklog download button Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5eec06e7-2ad7-0c40-ba71-9fc2f062c9d4@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox