public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Lorenz Stechauner <l.stechauner@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: storage/PBSEdit: add port field
Date: Thu, 7 Oct 2021 14:55:18 +0200	[thread overview]
Message-ID: <5eb47579-e1b9-49b4-ab2d-26fe88445e3f@proxmox.com> (raw)
In-Reply-To: <20211007124253.3484118-1-l.stechauner@proxmox.com>

there are a few ways to implement that and the commit message gives zero reasoning
about the chosen one, I do not really like that...

why not allowing one to enter it as suffix in the host field like we do in PBS for
the remotes.

An extra field is always distracting for newer users as it's yet another choice one can possible make,

On 07.10.21 14:42, Lorenz Stechauner wrote:
> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> ---
>  www/manager6/storage/PBSEdit.js | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js
> index fcbc9548..0d7b8033 100644
> --- a/www/manager6/storage/PBSEdit.js
> +++ b/www/manager6/storage/PBSEdit.js
> @@ -465,6 +465,13 @@ Ext.define('PVE.storage.PBSInputPanel', {
>  		fieldLabel: gettext('Server'),
>  		allowBlank: false,
>  	    },
> +	    {
> +		xtype: me.isCreate ? 'numberfield' : 'displayfield',
> +		name: 'port',
> +		value: 8007,
> +		fieldLabel: gettext('Port'),
> +		allowBlank: false,
> +	    },
>  	    {
>  		xtype: me.isCreate ? 'textfield' : 'displayfield',
>  		name: 'username',
> 





  reply	other threads:[~2021-10-07 12:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 12:42 Lorenz Stechauner
2021-10-07 12:55 ` Thomas Lamprecht [this message]
2021-10-07 12:58   ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5eb47579-e1b9-49b4-ab2d-26fe88445e3f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=l.stechauner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal