public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] fix #6138: ui: storage content: use locale for sorting filenames
Date: Tue, 4 Mar 2025 14:05:49 +0100	[thread overview]
Message-ID: <5e2c1c9f-ac96-4b6d-b86c-c6959de28a87@proxmox.com> (raw)
In-Reply-To: <20250205132207.2136187-1-d.csapak@proxmox.com>

Am 05.02.25 um 14:22 schrieb Dominik Csapak:
> by using 'localeCompare'.
> 
> Assume the files 'a', 'B' and 'c'. The current default sorting results
> in :
> 
> 'B'
> 'a'
> 'c'
> 
> (C collation)
> 
> With this patch we use locale dependent sorting, so the browser/client
> setting controls how it's sorted. For example with english, the list
> becomes:
> 
> 'a'
> 'B'
> 'c'
> 
> Which makes it easier to visually search for specific entries. Using the
> default settings here makes sense (so no explicit 'sensitivity' setting
> for example.), since that is whats most expected per locale.
> 
> Interestingly, the initial sorter (via the 'sorters' property of the
> store), cannot seem to reuse the sorter defined in the columns, so we
> have to specify it twice, once for the initial sort and once when the
> user clicks the column header.
> 
> Previously the default sorter was by 'volid' which was sometimes not
> even fully visible (i.e. 'local:100/vm-100...' becomes 'vm-100...')
> which lead to confusing sorting results, as 'base' volumes were
> interspersed with the normal vm volumes, but the list was sorted by vmid
> alphabetically (not numerical).
> 
> Now the result is sorted by what the user can see, which is IMO a better
> experience.
> 

While we're at it, should/can we make sorting numerically work too?
There is a 'numeric' option we could set, not sure if that's better or
not here and if that is intended to work for mixed strings like
soemthing9.yaml, something10.yaml or only for purely numeric ones.

> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>

Had to use utf8::decode() in the storage backend's get_subdir_files() to
be able to test with a path with special character 'รค' (to compare
Swedish and German ordering). Because the returned path from the API is
garbled otherwise. But that is orthogonal to the fix here, so

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>

> ---
>  www/manager6/storage/ContentView.js | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js
> index daefaf4f..a40880de 100644
> --- a/www/manager6/storage/ContentView.js
> +++ b/www/manager6/storage/ContentView.js
> @@ -43,10 +43,9 @@ Ext.define('PVE.storage.ContentView', {
>  		    content: content,
>  		},
>  	    },
> -	    sorters: {
> -		property: 'volid',
> -		direction: 'ASC',
> -	    },
> +	    sorters: [
> +		(a, b) => a.data.text.toString().localeCompare(b.data.text.toString()),
> +	    ],
>  	});
>  
>  	if (!me.sm) {
> @@ -153,6 +152,7 @@ Ext.define('PVE.storage.ContentView', {
>  		flex: 2,
>  		sortable: true,
>  		renderer: PVE.Utils.render_storage_content,
> +		sorter: (a, b) => a.data.text.toString().localeCompare(b.data.text.toString()),
>  		dataIndex: 'text',
>  	    },
>  	    'notes': {



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2025-03-04 13:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-05 13:22 Dominik Csapak
2025-03-04 13:05 ` Fiona Ebner [this message]
2025-03-04 13:14   ` Dominik Csapak
2025-03-04 13:30     ` Thomas Lamprecht
2025-03-04 14:15 ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5e2c1c9f-ac96-4b6d-b86c-c6959de28a87@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal