From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [RFC/PATCH storage] api: disk list: allow if an audit permission for the node is present
Date: Thu, 11 Mar 2021 14:16:44 +0100 [thread overview]
Message-ID: <5e0dbd3a-fcdd-2286-0a5e-0ec035bd0b86@proxmox.com> (raw)
In-Reply-To: <20210310092627.1684-1-f.ebner@proxmox.com>
On 10.03.21 10:26, Fabian Ebner wrote:
> as that seems to be the more natural permission path for listing a nodes local
> disks. For backwards compatibility, the old permission check has to be kept
> (relevant with propagate=0).
>
> This API call was originally part of the Ceph API and got copied here later,
> which might explain the current permission check.
>
> In the UI, the Disk panel is visible with a node audit permission, but the API
> call itself failed without the '/' audit permission.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/API2/Disks.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-03-11 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 9:26 [pve-devel] " Fabian Ebner
2021-03-11 13:16 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e0dbd3a-fcdd-2286-0a5e-0ec035bd0b86@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox