public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH container] setup: systemd-network: use correct values for dhcp-modes
Date: Fri, 9 Jun 2023 17:38:20 +0200	[thread overview]
Message-ID: <5dec1835-eb49-1515-bdc6-ac9406ad80bc@proxmox.com> (raw)
In-Reply-To: <20230609130551.338045-1-s.ivanov@proxmox.com>

On 09/06/2023 15:05, Stoiko Ivanov wrote:
> the change from v4->ipv4 happened 2015 in systemd commit
> cb9fc36a1211967e8c58b0502a26c42552ac8060 - so by now it should be
> safe to replace it for all containers relying on systemd-networkd.

yeah, especially as cgroup v2 switch brought us some lower bound
in what systemd version is supported by default, i.e., without
booting into legacy hierarchy again.

> 
> This change follows fb554c701f1e9cac4b278fd6b82a4f2b45da8acf (in
> pve-container) but in this case the issue is only cosmetic for now.
> 
> Noticed with a current arch-linux container
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> 
>  src/PVE/LXC/Setup/Base.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




      reply	other threads:[~2023-06-09 15:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09 13:05 [pve-devel] " Stoiko Ivanov
2023-06-09 15:38 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5dec1835-eb49-1515-bdc6-ac9406ad80bc@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal