public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>,
	pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager 4/7] ui: qga: note that freeze-fs-on-backup is deprecated
Date: Wed, 11 Mar 2026 16:57:59 +0100	[thread overview]
Message-ID: <5dd6a059-71f3-46e0-860b-1ea136550d10@proxmox.com> (raw)
In-Reply-To: <20260225154614.681858-5-m.sandoval@proxmox.com>

Am 25.02.26 um 4:46 PM schrieb Maximiliano Sandoval:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  www/manager6/form/AgentFeatureSelector.js | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js
> index 43d83a39..e7fa929c 100644
> --- a/www/manager6/form/AgentFeatureSelector.js
> +++ b/www/manager6/form/AgentFeatureSelector.js
> @@ -44,9 +44,10 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>                  ['isa', 'ISA'],
>              ],
>          },
> +        // TODO Remove these two items with Proxmox VE 10.
>          {
>              xtype: 'proxmoxcheckbox',
> -            boxLabel: gettext('Freeze/thaw guest filesystems on backup for consistency'),
> +            boxLabel: gettext('Deprecated. Freeze/thaw guest filesystems on backup for consistency'),

I'd prefer if there was a sentence like "Deprecated in favor of the more
general setting" after the existing description.

>              name: 'freeze-fs-on-backup',
>              reference: 'freeze_fs_on_backup',
>              bind: {





  reply	other threads:[~2026-03-11 15:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 15:45 [PATCH manager 0/7] ui: qga: add checkbox for guest-fsfreeze Maximiliano Sandoval
2026-02-25 15:45 ` [PATCH manager 1/7] ui: utils: support guest-fsfreeze at render_qga_features Maximiliano Sandoval
2026-03-11 15:58   ` Fiona Ebner
2026-02-25 15:45 ` [PATCH manager 2/7] ui: qga: merge translatable string Maximiliano Sandoval
2026-03-11 15:58   ` Fiona Ebner
2026-02-25 15:45 ` [PATCH manager 3/7] ui: qga: move freeze-fs-on-backup to advanced opts Maximiliano Sandoval
2026-03-11 15:58   ` Fiona Ebner
2026-02-25 15:45 ` [PATCH manager 4/7] ui: qga: note that freeze-fs-on-backup is deprecated Maximiliano Sandoval
2026-03-11 15:57   ` Fiona Ebner [this message]
2026-02-25 15:45 ` [PATCH manager 5/7] ui: qga: add checkbox for guest-fsfreeze Maximiliano Sandoval
2026-03-11 15:58   ` Fiona Ebner
2026-02-25 15:45 ` [PATCH manager 6/7] ui: qga: call parameter me instead of this Maximiliano Sandoval
2026-03-11 15:58   ` Fiona Ebner
2026-02-25 15:45 ` [PATCH manager 7/7] ui: qga: hide freeze-fs-on-backup check if undefined Maximiliano Sandoval
2026-03-11 15:58   ` Fiona Ebner
2026-03-13  9:56     ` superseded: " Maximiliano Sandoval
2026-02-25 16:03 ` [PATCH manager 0/7] ui: qga: add checkbox for guest-fsfreeze Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5dd6a059-71f3-46e0-860b-1ea136550d10@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal