From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, d.tschlatscher@proxmox.com
Subject: Re: [pve-devel] [PATCH storage v2 1/2] fix #3972: Remove the .notes file when a backup is deleted
Date: Wed, 18 May 2022 11:16:33 +0200 [thread overview]
Message-ID: <5d7c6558-f35c-568e-e09f-828f7d1c0d40@proxmox.com> (raw)
In-Reply-To: <20220512131753.126854-1-d.tschlatscher@proxmox.com>
Am 12.05.22 um 15:17 schrieb Daniel Tschlatscher:
> unlink $logpath or warn "removing log file $logpath failed: $!\n";
Forgot to say that we could switch to using PVE::RESTEnvironment's
log_warn here
> }
> }
> +
> + if (defined($notesfn)) {
> + my $notespath = "$dirname/$notesfn";
> + if (-e $notespath) {
> + unlink $notespath or warn "removing notes file $notespath failed: $!\n";
and here
> + }
> + }
> }
prev parent reply other threads:[~2022-05-18 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 13:17 Daniel Tschlatscher
2022-05-12 13:17 ` [pve-devel] [PATCH storage v2 2/2] fix #3972: test: Adapt test cases to changes in archive_info Daniel Tschlatscher
2022-05-18 9:08 ` Fabian Ebner
2022-05-18 9:08 ` [pve-devel] [PATCH storage v2 1/2] fix #3972: Remove the .notes file when a backup is deleted Fabian Ebner
2022-05-18 9:16 ` Fabian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d7c6558-f35c-568e-e09f-828f7d1c0d40@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox