Re: [PATCH pve-manager 2/2] fix #5032: ui: qemu agent: add set-time-on-resume option

[Arthur Bied-Charreton <a.bied-charreton@proxmox.com>]

On Fri, Jun 12, 2026 at 02:29:42PM +0200, Jakob Klocker wrote:

One nit inline

Reviewed-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>
Tested-by: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>

> Expose the new agent configuration option `set-time-on-resume`
> in the VM configuration GUI.
> 
> This allows enabling/disabling automatic guest clock
> synchronization after resume from saved state or snapshot
> restore with RAM.
> 
> Link: https://bugzilla.proxmox.com/show_bug.cgi?id=5032
> Signed-off-by: Jakob Klocker <j.klocker@proxmox.com>
> ---
>  www/manager6/Utils.js                     |  2 ++
>  www/manager6/form/AgentFeatureSelector.js | 18 ++++++++++++++++++
>  2 files changed, 20 insertions(+)
> 
> diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
> index 2ed4e65d..ee55a6ac 100644
> --- a/www/manager6/Utils.js
> +++ b/www/manager6/Utils.js
> @@ -523,6 +523,8 @@ Ext.define('PVE.Utils', {
>                      continue;
>                  } else if (key === 'freeze-fs' && PVE.Parser.parseBoolean(value)) {
>                      continue;
> +                } else if (key === 'set-time-on-resume' && PVE.Parser.parseBoolean(value)) {
> +                    continue;
>                  } else if (PVE.Parser.parseBoolean(value)) {
>                      displayText = Proxmox.Utils.enabledText;
>                  }
> diff --git a/www/manager6/form/AgentFeatureSelector.js b/www/manager6/form/AgentFeatureSelector.js
> index 3cae4194..ba21a383 100644
> --- a/www/manager6/form/AgentFeatureSelector.js
> +++ b/www/manager6/form/AgentFeatureSelector.js
> @@ -45,6 +45,18 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>                  hidden: '{freeze_fs.checked}',
>              },
>          },
> +        {
> +            xtype: 'proxmoxcheckbox',
> +            boxLabel: gettext('Set guest clock to host after resume from saved state'),
nit: maybe "synchronize guest clock with the host's ..." would be
clearer here
> +            name: 'set-time-on-resume',
> +            reference: 'set_time_on_resume',
> +            bind: {
> +                disabled: '{!enabled.checked}',
> +            },
> +            disabled: true,
> +            uncheckedValue: '0',
> +            defaultValue: '1',
> +        },
>          {
>              xtype: 'displayfield',
>              userCls: 'pmx-hint',
> @@ -74,6 +86,9 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>          if (PVE.Parser.parseBoolean(values['freeze-fs'])) {
>              delete values['freeze-fs'];
>          }
> +        if (PVE.Parser.parseBoolean(values['set-time-on-resume'])) {
> +            delete values['set-time-on-resume'];
> +        }
>  
>          const agentstr = PVE.Parser.printPropertyString(values, 'enabled');
>          return { agent: agentstr };
> @@ -90,6 +105,9 @@ Ext.define('PVE.form.AgentFeatureSelector', {
>          if (!Ext.isDefined(res['freeze-fs'])) {
>              res['freeze-fs'] = 1;
>          }
> +        if (!Ext.isDefined(res['set-time-on-resume'])) {
> +            res['set-time-on-resume'] = 1;
> +        }
>  
>          this.callParent([res]);
>      },
> -- 
> 2.47.3
> 
> 
> 
>