From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Gabriel Goller <g.goller@proxmox.com>, pve-devel@lists.proxmox.com
Subject: [pve-devel] applied-series: [PATCH 1/4] frr: bump from 8.5.2 to 10.2.1
Date: Fri, 7 Mar 2025 15:06:58 +0100 [thread overview]
Message-ID: <5cf29bf6-5cab-4f4e-b436-60fd5ed1313a@proxmox.com> (raw)
In-Reply-To: <20250307122945.307426-1-g.goller@proxmox.com>
On 07/03/2025 13:29, Gabriel Goller wrote:
> This includes a new frr-test-tools package that we are not interested in
> (it's a testing package), so we ignore it with a BuildProfile.
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
> Makefile | 2 +-
> debian/control | 9 +++++++++
> frr | 2 +-
> 3 files changed, 11 insertions(+), 2 deletions(-)
>
>
applied series, thanks!
I adapted the bump commit to use our common commit subject style and more
importantly I fixed the versioning. As FRR is not developed by us we cannot
use native versioning but need to split the native version and the packaging
revision with a minus; this also ensures upgrades are correctly pulled in
independently if the native part gets bumped by upstream or we bump the
revision again for the same upstream version due to (packaging) changes on
top of an upstream version that got already released to our package repos.
I got some info for this in the packaging guide in our internal wiki (might
make that public in the future) and it basically follows Debian, so you can
also check out the respective section [0] of the Debian Policy Manual.
[0]: https://www.debian.org/doc/debian-policy/ch-controlfields.html#version
I also backported libyang3 to satisfy updated build-dependency requirements
of upstream, doing so itself is not a lot of work, but having to find out
that this is needed is not only some extra work that can be avoided, it's
also rather risky to slip through if it would only matter at runtime,
causing some ugly breakage. So, the next time please ensure to build in a
clean environment, e.g., using `sbuild` and a relatively minimal base image,
and also check upstream for any newer dependency needs and update the
Build-Depends section in debian/control accordingly.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-03-07 14:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 12:29 [pve-devel] " Gabriel Goller
2025-03-07 12:29 ` [pve-devel] [PATCH 2/4] frr: port patches to latest stable version, add topotests Gabriel Goller
2025-03-07 12:29 ` [pve-devel] [PATCH 3/4] frr: add the dummy_as_loopback patch series, enable it by default Gabriel Goller
2025-03-07 12:29 ` [pve-devel] [PATCH 4/4] debian: update changelog Gabriel Goller
2025-03-07 12:31 ` [pve-devel] [PATCH 1/4] frr: bump from 8.5.2 to 10.2.1 Gabriel Goller
2025-03-11 10:56 ` DERUMIER, Alexandre via pve-devel
2025-03-11 13:27 ` Gabriel Goller
[not found] ` <b071a6e9d7e234a14eddabf4f7bd3ce1dbd6167c.camel@groupe-cyllene.com>
2025-03-11 14:11 ` Thomas Lamprecht
2025-03-11 16:16 ` DERUMIER, Alexandre via pve-devel
2025-03-07 14:06 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cf29bf6-5cab-4f4e-b436-60fd5ed1313a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal