* [pve-devel] [PATCH installer] warn if maxvz is set and <= 4 GiB
@ 2024-11-19 10:45 Mira Limbeck
2024-11-19 10:46 ` Mira Limbeck
2024-11-19 11:55 ` Maximiliano Sandoval
0 siblings, 2 replies; 4+ messages in thread
From: Mira Limbeck @ 2024-11-19 10:45 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
---
Proxmox/Install.pm | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index c64e1d4..da8fb55 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -555,6 +555,10 @@ sub create_lvm_volumes {
my $maxvz = Proxmox::Install::Config::get_maxvz();
if ($iso_env->{product} eq 'pve' && !defined($maxvz)) {
Proxmox::UI::message("Skipping auto-creation of LVM thinpool for guest data due to low space.");
+ } elsif ($iso_env->{product} eq 'pve') {
+ Proxmox::UI::message(
+ "Skipping auto-creation of LVM thinpool for guest data, Maximum data volume size set too low."
+ );
}
$datadev = undef;
}
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [pve-devel] [PATCH installer] warn if maxvz is set and <= 4 GiB
2024-11-19 10:45 [pve-devel] [PATCH installer] warn if maxvz is set and <= 4 GiB Mira Limbeck
@ 2024-11-19 10:46 ` Mira Limbeck
2024-11-19 11:55 ` Maximiliano Sandoval
1 sibling, 0 replies; 4+ messages in thread
From: Mira Limbeck @ 2024-11-19 10:46 UTC (permalink / raw)
To: pve-devel
On 11/19/24 11:45, Mira Limbeck wrote:
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> Proxmox/Install.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
> index c64e1d4..da8fb55 100644
> --- a/Proxmox/Install.pm
> +++ b/Proxmox/Install.pm
> @@ -555,6 +555,10 @@ sub create_lvm_volumes {
> my $maxvz = Proxmox::Install::Config::get_maxvz();
> if ($iso_env->{product} eq 'pve' && !defined($maxvz)) {
> Proxmox::UI::message("Skipping auto-creation of LVM thinpool for guest data due to low space.");
> + } elsif ($iso_env->{product} eq 'pve') {
> + Proxmox::UI::message(
> + "Skipping auto-creation of LVM thinpool for guest data, Maximum data volume size set too low."
> + );
> }
> $datadev = undef;
> }
Sent it a bit too soon, maybe we want to check if $maxvz is 0 and don't
warn in that case?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [pve-devel] [PATCH installer] warn if maxvz is set and <= 4 GiB
2024-11-19 10:45 [pve-devel] [PATCH installer] warn if maxvz is set and <= 4 GiB Mira Limbeck
2024-11-19 10:46 ` Mira Limbeck
@ 2024-11-19 11:55 ` Maximiliano Sandoval
2024-11-19 11:59 ` Mira Limbeck
1 sibling, 1 reply; 4+ messages in thread
From: Maximiliano Sandoval @ 2024-11-19 11:55 UTC (permalink / raw)
To: Proxmox VE development discussion
Mira Limbeck <m.limbeck@proxmox.com> writes:
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> Proxmox/Install.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
> index c64e1d4..da8fb55 100644
> --- a/Proxmox/Install.pm
> +++ b/Proxmox/Install.pm
> @@ -555,6 +555,10 @@ sub create_lvm_volumes {
> my $maxvz = Proxmox::Install::Config::get_maxvz();
> if ($iso_env->{product} eq 'pve' && !defined($maxvz)) {
> Proxmox::UI::message("Skipping auto-creation of LVM thinpool for guest data due to low space.");
> + } elsif ($iso_env->{product} eq 'pve') {
> + Proxmox::UI::message(
> + "Skipping auto-creation of LVM thinpool for guest data, Maximum data volume size set too low."
Is "Maximum" intentionally uppercased?
> + );
> }
> $datadev = undef;
> }
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [pve-devel] [PATCH installer] warn if maxvz is set and <= 4 GiB
2024-11-19 11:55 ` Maximiliano Sandoval
@ 2024-11-19 11:59 ` Mira Limbeck
0 siblings, 0 replies; 4+ messages in thread
From: Mira Limbeck @ 2024-11-19 11:59 UTC (permalink / raw)
To: pve-devel
On 11/19/24 12:55, Maximiliano Sandoval wrote:
>
> Mira Limbeck <m.limbeck@proxmox.com> writes:
>
>> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
>> ---
>> Proxmox/Install.pm | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
>> index c64e1d4..da8fb55 100644
>> --- a/Proxmox/Install.pm
>> +++ b/Proxmox/Install.pm
>> @@ -555,6 +555,10 @@ sub create_lvm_volumes {
>> my $maxvz = Proxmox::Install::Config::get_maxvz();
>> if ($iso_env->{product} eq 'pve' && !defined($maxvz)) {
>> Proxmox::UI::message("Skipping auto-creation of LVM thinpool for guest data due to low space.");
>> + } elsif ($iso_env->{product} eq 'pve') {
>> + Proxmox::UI::message(
>> + "Skipping auto-creation of LVM thinpool for guest data, Maximum data volume size set too low."
>
> Is "Maximum" intentionally uppercased?
>
See v2:
https://lore.proxmox.com/pve-devel/20241119111241.97092-1-m.limbeck@proxmox.com/T/#u
Forgot to change `,` to `.` when changing the text.
>> + );
>> }
>> $datadev = undef;
>> }
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-19 11:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-19 10:45 [pve-devel] [PATCH installer] warn if maxvz is set and <= 4 GiB Mira Limbeck
2024-11-19 10:46 ` Mira Limbeck
2024-11-19 11:55 ` Maximiliano Sandoval
2024-11-19 11:59 ` Mira Limbeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox