From: Mira Limbeck <m.limbeck@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH installer] warn if maxvz is set and <= 4 GiB
Date: Tue, 19 Nov 2024 12:59:02 +0100 [thread overview]
Message-ID: <5ccc4a87-d9dc-45b6-93fd-532d326266c1@proxmox.com> (raw)
In-Reply-To: <s8ov7wj309k.fsf@proxmox.com>
On 11/19/24 12:55, Maximiliano Sandoval wrote:
>
> Mira Limbeck <m.limbeck@proxmox.com> writes:
>
>> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
>> ---
>> Proxmox/Install.pm | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
>> index c64e1d4..da8fb55 100644
>> --- a/Proxmox/Install.pm
>> +++ b/Proxmox/Install.pm
>> @@ -555,6 +555,10 @@ sub create_lvm_volumes {
>> my $maxvz = Proxmox::Install::Config::get_maxvz();
>> if ($iso_env->{product} eq 'pve' && !defined($maxvz)) {
>> Proxmox::UI::message("Skipping auto-creation of LVM thinpool for guest data due to low space.");
>> + } elsif ($iso_env->{product} eq 'pve') {
>> + Proxmox::UI::message(
>> + "Skipping auto-creation of LVM thinpool for guest data, Maximum data volume size set too low."
>
> Is "Maximum" intentionally uppercased?
>
See v2:
https://lore.proxmox.com/pve-devel/20241119111241.97092-1-m.limbeck@proxmox.com/T/#u
Forgot to change `,` to `.` when changing the text.
>> + );
>> }
>> $datadev = undef;
>> }
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-19 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 10:45 Mira Limbeck
2024-11-19 10:46 ` Mira Limbeck
2024-11-19 11:55 ` Maximiliano Sandoval
2024-11-19 11:59 ` Mira Limbeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ccc4a87-d9dc-45b6-93fd-532d326266c1@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox