Re: [pve-devel] [PATCH v2 qemu] block/gluster: provider more context for deprecation warning

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 02.06.25 um 13:07 schrieb Fiona Ebner:
> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes in v2:
> * Instead of removing the warning, provide more context.
> 
>  block/gluster.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/block/gluster.c b/block/gluster.c
> index c3a9555591..71c4a60b02 100644
> --- a/block/gluster.c
> +++ b/block/gluster.c
> @@ -816,7 +816,11 @@ static int qemu_gluster_open(BlockDriverState *bs,  QDict *options,
>          goto out;
>      }
>  
> -    warn_report_once("'gluster' is deprecated");
> +    warn_report_once("Native 'gluster' support will be deprecated and removed"
> +                     " in Proxmox VE 9.");
> +    warn_report_once("Before upgrading, switch to accessing your Gluster"
> +                     " storage as a directory storage or migrate to another"
> +                     " storage type.");
>  
>      filename = qemu_opt_get(opts, GLUSTER_OPT_FILENAME);
>  

Acked-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

can you please apply this on the stable-bookworm and upload
a new version so that we can get this warning out over the
next few weeks? Maybe there are some stable fixes that make
a bump more worthwhile, but no hard feelings there.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel