From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 qemu-server 4/7] tests: add migration alias check
Date: Fri, 2 Jun 2023 13:29:06 +0200 [thread overview]
Message-ID: <5b80d8ec-b7d3-12bb-23dc-6fa426045eeb@proxmox.com> (raw)
In-Reply-To: <20230601135342.2903359-5-a.lauterer@proxmox.com>
Am 01.06.23 um 15:53 schrieb Aaron Lauterer:
> @@ -351,9 +387,9 @@ my $source_vdisks = {
> {
> 'ctime' => '1589277334',
> 'format' => 'raw',
> - 'size' => 108003328,
> - 'vmid' => '111',
> - 'volid' => 'local-zfs:vm-111-disk-0',
> + 'size' => 4294967296,
> + 'vmid' => '123',
> + 'volid' => 'local-zfs:vm-123-disk-0',
Why is this changed?
> },
> {
> 'format' => 'raw',
> @@ -364,6 +400,24 @@ my $source_vdisks = {
> 'volid' => 'local-zfs:vm-4567-disk-0',
> },
> ],
> + 'alias-zfs' => [
> + {
> + 'ctime' => '1589277334',
> + 'format' => 'raw',
> + 'size' => 108003328,
> + 'vmid' => '111',
> + 'volid' => 'local-zfs:vm-111-disk-0',
> + },
> + ],
> + 'alias-zfs-2' => [
> + {
> + 'ctime' => '1589277334',
> + 'format' => 'raw',
> + 'size' => 108003328,
> + 'vmid' => '111',
> + 'volid' => 'local-zfs:vm-111-disk-0',
> + },
> + ],
Those are added for 111 instead of 123 and the volids also are not
corresponding to the storage.
If you'd die in the mocked version of volume_size_info when not finding
the volid, you would have noticed ;)
next prev parent reply other threads:[~2023-06-02 11:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 13:53 [pve-devel] [PATCH v3 qemu-server, container, docs 0/7] migration: don't scan all storages, fail on aliases Aaron Lauterer
2023-06-01 13:53 ` [pve-devel] [PATCH v3 qemu-server 1/7] migration: only migrate disks used by the guest Aaron Lauterer
2023-06-02 9:45 ` Fiona Ebner
2023-06-02 9:50 ` Fiona Ebner
2023-06-05 12:43 ` Aaron Lauterer
2023-06-01 13:53 ` [pve-devel] [PATCH v3 qemu-server 2/7] tests: add migration test for pending disk Aaron Lauterer
2023-06-01 13:53 ` [pve-devel] [PATCH v3 qemu-server 3/7] migration: fail when aliased volume is detected Aaron Lauterer
2023-06-01 13:53 ` [pve-devel] [PATCH v3 qemu-server 4/7] tests: add migration alias check Aaron Lauterer
2023-06-02 11:29 ` Fiona Ebner [this message]
2023-06-01 13:53 ` [pve-devel] [PATCH v3 container 5/7] migration: only migrate volumes used by the guest Aaron Lauterer
2023-06-02 11:42 ` Fiona Ebner
2023-06-01 13:53 ` [pve-devel] [PATCH v3 container 6/7] migration: fail when aliased volume is detected Aaron Lauterer
2023-06-01 13:53 ` [pve-devel] [PATCH v3 docs 7/7] storage: add hint to avoid storage aliasing Aaron Lauterer
2023-06-02 11:51 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b80d8ec-b7d3-12bb-23dc-6fa426045eeb@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox