public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] ui: cluster info: fix displaying error
@ 2023-01-23 13:45 Fiona Ebner
  2023-01-24 15:15 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Fiona Ebner @ 2023-01-23 13:45 UTC (permalink / raw)
  To: pve-devel

The function to set the error mask expects the message as a string,
not the error object.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 www/manager6/dc/Cluster.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/dc/Cluster.js b/www/manager6/dc/Cluster.js
index afe14bf4..22b62cc8 100644
--- a/www/manager6/dc/Cluster.js
+++ b/www/manager6/dc/Cluster.js
@@ -72,7 +72,7 @@ Ext.define('PVE.ClusterAdministration', {
 			    let msg = Proxmox.Utils.getResponseErrorMessage(error);
 			    if (error.status !== 424 && !msg.match(/node is not in a cluster/i)) {
 				// an actual error, not just the "not in a cluster one", so show it!
-				Proxmox.Utils.setErrorMask(this.getView(), error);
+				Proxmox.Utils.setErrorMask(this.getView(), msg);
 			    }
 			}
 			vm.set('totem', {});
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH manager] ui: cluster info: fix displaying error
  2023-01-23 13:45 [pve-devel] [PATCH manager] ui: cluster info: fix displaying error Fiona Ebner
@ 2023-01-24 15:15 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2023-01-24 15:15 UTC (permalink / raw)
  To: Proxmox VE development discussion, Fiona Ebner

Am 23/01/2023 um 14:45 schrieb Fiona Ebner:
> The function to set the error mask expects the message as a string,
> not the error object.
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  www/manager6/dc/Cluster.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-01-24 15:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 13:45 [pve-devel] [PATCH manager] ui: cluster info: fix displaying error Fiona Ebner
2023-01-24 15:15 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal