Re: [pve-devel] applied: [RFC qemu-server] avoid setting lun number for drives when pvscsi controller is used

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 17.06.21 09:29, Stefan Reiter wrote:
> On 16/06/2021 20:27, Thomas Lamprecht wrote:
>> On 13.04.21 10:24, Fabian Ebner wrote:
>>> Reported in the community forum[0].
>>>
>>> In QEMU's hw/scsi/vmw_pvscsi.c in the SCSIBusInfo struct, the max_lun property
>>> is set to 0. This means that in our stack, one cannot have multiple disks and
>>> use 'scsihw: pvscsi' currently, as kvm would fail with
>>>      bad scsi device lun: 1
>>>
>>> Instead of increasing the lun number, increase the scsi-id, as we already do for
>>> lsi.* (in hw/scsi/lsi53c895a.c the max_lun property is also 0).
>>>
>>> [0]: https://forum.proxmox.com/threads/kvm-bad-scsi-device-lun-1.84318/
>>>
>>> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
>>> ---
>>>
>>> I'm not experienced in this area, so not at all sure if this is the proper
>>> solution/workaround.
>>>
>>>   PVE/QemuServer.pm | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>>
>>
>> applied, with Stefans R-b/T-b tag, thanks to both!
>>
>> just to be sure: I assume that migration from old -> new is OK and was tested?
>>
> 
> Yes, VMs with one pvscsi disk can be migrated forward, and ones with multiple (where it might have caused incompatibility) didn't work to begin with.

Ack, thanks for the confirmation.