From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: [pve-devel] applied: [PATCH v2 qemu-server] fix #2570: add 'keephugepages' config
Date: Wed, 2 Sep 2020 14:10:01 +0200 [thread overview]
Message-ID: <5a413195-9e1b-4842-7b11-dd9c1a94964e@proxmox.com> (raw)
In-Reply-To: <20200902090337.10970-1-s.reiter@proxmox.com>
On 02.09.20 11:03, Stefan Reiter wrote:
> We already keep hugepages if they are created with the kernel
> commandline (hugepagesz=x hugepages=y), but some setups (specifically
> hugepages across multiple NUMA nodes) cannot be configured that way.
> Since we always clear these hugepages at VM shutdown, rebooting a VM
> that uses them might not work, since the requested count might not be
> available anymore by the time we want to use them (also, we would then
> no longer allocate them correctly on the NUMA nodes).
>
> Add a 'keephugepages' parameter to skip cleanup and simply leave them
> untouched.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> v2:
> * rebase
>
> PVE/QemuServer.pm | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2020-09-02 12:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 9:03 [pve-devel] " Stefan Reiter
2020-09-02 12:10 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a413195-9e1b-4842-7b11-dd9c1a94964e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox