From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] btrfs: call free_image correctly
Date: Wed, 22 Sep 2021 08:52:23 +0200 [thread overview]
Message-ID: <5a24e583-10c0-63b6-a159-953f47854d22@proxmox.com> (raw)
In-Reply-To: <20210920102302.75130-1-f.ebner@proxmox.com>
On 20.09.21 12:23, Fabian Ebner wrote:
> Currently, 'PVE::Storage::DirPlugin' is implicitly passed along as
> $class, which means that if the base class's free_image calls another
> method (e.g. filesystem_path) then the DirPlugin's method will be
> used, rather than the one from BTRFSPlugin. Change it so that $class
> itself is passed along.
>
> See also commit 279d9de5108f6fc6f2d31f77f1b41d6dc7a67cb9 for context,
> where the approach in this patch was suggested.
>
> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/Storage/BTRFSPlugin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-09-22 6:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 10:23 [pve-devel] " Fabian Ebner
2021-09-22 6:52 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a24e583-10c0-63b6-a159-953f47854d22@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox