public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH v2 qemu 1/2] block/gluster: correctly set max_pdiscard which is int64_t
Date: Wed, 11 May 2022 12:08:13 +0200	[thread overview]
Message-ID: <5a1e8922-3c80-1534-e08a-9c1e72908be6@proxmox.com> (raw)
In-Reply-To: <20220506123836.99473-1-f.ebner@proxmox.com>

Am 5/6/22 um 14:38 schrieb Fabian Ebner:
> Previously, max_pdiscard would be zero in the following assertion:
> qemu-system-x86_64: ../block/io.c:3166: bdrv_co_pdiscard: Assertion
> `max_pdiscard >= bs->bl.request_alignment' failed.
> 
> Fixes: 0c8022876f ("block: use int64_t instead of int in driver discard handlers")
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Changes from v1:
>     * Re-send as patch so both fixes can be applied independently.
> 
> Reported in the community forum:
> https://forum.proxmox.com/threads/108875
> and thanks to Mira for telling me how to reproduce it.
> 
>  block/gluster.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied both patches, thanks!




      parent reply	other threads:[~2022-05-11 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 12:38 [pve-devel] " Fabian Ebner
2022-05-06 12:38 ` [pve-devel] [PATCH v2 qemu 2/2] ui/vnc.c: Fixed a deadlock bug Fabian Ebner
2022-05-11 10:08 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a1e8922-3c80-1534-e08a-9c1e72908be6@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal