public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] SPAM: [PATCH pve-network 0/2] fix #5949
Date: Thu, 5 Dec 2024 17:50:56 +0100	[thread overview]
Message-ID: <59f7c975-2de5-4e6a-a2db-e650f0306563@proxmox.com> (raw)
In-Reply-To: <mailman.831.1732813825.391.pve-devel@lists.proxmox.com>

This patch series would change the behavior of zones with DHCP enabled
as follows:

Currently you need to explicitly configure a DHCP range, otherwise DHCP
doesn't work. With this patch series, an IP *always* gets allocated in
the IPAM when DHCP is enabled and served via DHCP.

This is an okay change in behavior I'd say, since it makes it easier to
just use DHCP if you want to manage the whole prefix via DHCP. We should
probably document it though.
It would also change the behavior for current setups that have DHCP
enabled, but no DHCP-Range configured. Might be a fringe case, but maybe
still worth to consider since those users would suddenly have a DHCP
server running on their PVE node when they re-apply the SDN configuration.


Another thing I noticed while testing:

Since we now use add_next_freeip() as well, this function does not save
the VMID in the PVE IPAM, leading to entries with no VMID and hostname
(see PVEPlugin). Would be nice if we added that as well to the
add_next_freeip() function - it already is there in add_range_next_freeip()


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2024-12-05 16:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-28 17:09 Lou Lecrivain via pve-devel
2024-12-05 15:49 ` Stefan Hanreich
2024-12-05 15:56   ` Lou Lecrivain via pve-devel
2024-12-05 16:50 ` Stefan Hanreich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59f7c975-2de5-4e6a-a2db-e650f0306563@proxmox.com \
    --to=s.hanreich@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal