From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH container] config list helper: fix return type of vmid for container index API enpoint
Date: Thu, 11 Apr 2024 13:57:52 +0200 [thread overview]
Message-ID: <59da9fea-a8fd-48d7-93d6-b1d3537ff50d@proxmox.com> (raw)
In-Reply-To: <20231205113532.58166-1-f.ebner@proxmox.com>
Am 05.12.23 um 12:35 schrieb Fiona Ebner:
> The schema declares it to be an integer. Done in the config_list()
> helper, to ensure consistency for the following existing code in
> vmstatus():
>
>> my $list = $opt_vmid ? { $opt_vmid => { type => 'lxc', vmid => int($opt_vmid) }} : config_list();
>
> Should not cause any issues for other callers of the helper.
>
> Reported in the community forum:
> https://forum.proxmox.com/threads/137628/
>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Ping
next prev parent reply other threads:[~2024-04-11 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-05 11:35 Fiona Ebner
2024-04-11 11:57 ` Fiona Ebner [this message]
2024-04-11 13:29 ` [pve-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59da9fea-a8fd-48d7-93d6-b1d3537ff50d@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox