From: "Michael Köppl" <m.koeppl@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container/qemu-server/storage v8 00/10] fix #3711 and adapt drive detach/remove behavior
Date: Tue, 15 Jul 2025 18:29:36 +0200 [thread overview]
Message-ID: <59b49982-bc13-477d-8c00-f9509cd5d9b1@proxmox.com> (raw)
In-Reply-To: <79e1d338-d492-483d-87b1-024c52c237c0@proxmox.com>
On 7/8/25 13:09, Lukas Wagner wrote:
> Something that I have noticed is that when you have a second disk/mountpoint on
> some storage, detach the disk/mountpoint, remove the storage and then
> try to remove the unused disk, there is a difference in behavior between
> containers and VMs. For VMs, the ununused disk can be removed, while for containers
> the removal fails with:
>
> unused0: unable to apply pending change unused0 : storage 'test' does not exist
>
Sorry for the late reply and thanks for having a look at this! Good
catch. Considering some of the other patches in this series are aimed at
streamlining the behavior of VMs and CTs, I'll add a check similar to
the one done for VMs in a v9.
>
> Also did a brief review of the code. I'm not really familiar with these parts
> of our stack, but from my point of view these changes look fine.
>
>
> Tested-by: Lukas Wagner <l.wagner@proxmox.com>
> Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-15 16:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-26 16:06 Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH storage v8 1/2] vdisk_free: print warning if underlying storage does not exist Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH storage v8 2/2] parse_volname: print warning if storage does not exists Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 1/4] fix #3711: warn about storage errors during mountpoint delete Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 2/4] destroy_lxc, delete_mp_volume: rename $volume to $volid Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 3/4] config: ensure valid volid through parse_volume() Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH container v8 4/4] add linked clone check when destroying container template Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 1/4] adapt linked clone check to not die if an error occurs during check Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 2/4] fix #3711: make removal of VM possible if store does not exist anymore Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 3/4] destroy_vm: use log_warn for vdisk_free errors for consistency Michael Köppl
2025-06-26 16:06 ` [pve-devel] [PATCH qemu-server v8 4/4] display warnings for storage errors or if storage no longer exists Michael Köppl
2025-07-08 11:09 ` [pve-devel] [PATCH container/qemu-server/storage v8 00/10] fix #3711 and adapt drive detach/remove behavior Lukas Wagner
2025-07-15 16:29 ` Michael Köppl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59b49982-bc13-477d-8c00-f9509cd5d9b1@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox