Re: [pve-devel] [PATCH v1 installer/docs 00/18] add automated/unattended installation

[Aaron Lauterer <a.lauterer@proxmox.com>]

On 2/8/24 11:34, Christoph Heiss wrote:
> On Thu, Feb 08, 2024 at 11:26:01AM +0100, Christoph Heiss wrote:
>> Did some testing, doing various installs using
>> * different filesystems
>> * pre/post hooks
>> * simple udev matching for disks and network interfaces
>>
>> I did not exercise the udev-matching exhaustively, but as it is pretty
>> generic, that should cover it.
>>
>> The `proxmox-installer-filter` is a nice tooling addition as well!
>> Maybe we could also provide some tool in the future which would do some
>> (basic) sanity checking/validating on the `answer.toml`, to avoid people
>> having to do test cycles on a real machine.

good point. I guess just checking if it parses without errors is okay for a first version. Will work on something for v3.

>>
>> As for the global `{pre,post}_commands` hooks - ,
> Whoops, got a bit cut of here. In any case; a though of mine:
> For the post-hook (at least), these run after the installation has
> completely finished. So changing anything inside the new installation -
> for which this hook could be pretty useful - can only be done in a
> rather hacky way.
> 
> This probably should be some future addition on its own, but maybe
> provide the user also with some hook to modify the newly installed
> system, possibly running the commands inside a chroot? Or simply passing
> the (mount) path via environment variable or such.
> 
> But this will need some deeper hooking into to the installation code -
> just spilling my thoughts here.

yeah, we had the idea floating around of providing a small tool similar to "arch-chroot" to easily chroot into the installation.

> 
>>
>> So please consider this:
>>
>> Tested-by: Christoph Heiss <c.heiss@proxmox.com>
>>
>> Also, already left some review comments on the individual patches, but
>> nothing too major.
>>
>> On Tue, Jan 23, 2024 at 06:00:35PM +0100, Aaron Lauterer wrote:
> [..]