public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH widget-toolkit] tfa: paperkey: cleanup iframes for printing after window close
@ 2023-04-03 12:28 Aaron Lauterer
  2023-05-26  8:34 ` Aaron Lauterer
  2023-05-28 17:40 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Aaron Lauterer @ 2023-04-03 12:28 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
similar as in
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=b380cb5814ec551588dfcbd6c5ed190f01d54029

 src/window/AddTfaRecovery.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/window/AddTfaRecovery.js b/src/window/AddTfaRecovery.js
index 174d553..dba4454 100644
--- a/src/window/AddTfaRecovery.js
+++ b/src/window/AddTfaRecovery.js
@@ -220,5 +220,6 @@ ${keyString}
 
 	printFrame.src = "data:text/html;base64," + btoa(html);
 	document.body.appendChild(printFrame);
+	me.on('destroy', () => document.body.removeChild(printFrame));
     },
 });
-- 
2.30.2





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH widget-toolkit] tfa: paperkey: cleanup iframes for printing after window close
  2023-04-03 12:28 [pve-devel] [PATCH widget-toolkit] tfa: paperkey: cleanup iframes for printing after window close Aaron Lauterer
@ 2023-05-26  8:34 ` Aaron Lauterer
  2023-05-28 17:40 ` [pve-devel] applied: " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Aaron Lauterer @ 2023-05-26  8:34 UTC (permalink / raw)
  To: pve-devel

ping?




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH widget-toolkit] tfa: paperkey: cleanup iframes for printing after window close
  2023-04-03 12:28 [pve-devel] [PATCH widget-toolkit] tfa: paperkey: cleanup iframes for printing after window close Aaron Lauterer
  2023-05-26  8:34 ` Aaron Lauterer
@ 2023-05-28 17:40 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2023-05-28 17:40 UTC (permalink / raw)
  To: Proxmox VE development discussion, Aaron Lauterer

Am 03/04/2023 um 14:28 schrieb Aaron Lauterer:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> similar as in
> https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=b380cb5814ec551588dfcbd6c5ed190f01d54029

added the infor of above into the commit message, such cross references
have always some merit.

> 
>  src/window/AddTfaRecovery.js | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-05-28 17:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-03 12:28 [pve-devel] [PATCH widget-toolkit] tfa: paperkey: cleanup iframes for printing after window close Aaron Lauterer
2023-05-26  8:34 ` Aaron Lauterer
2023-05-28 17:40 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal