public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH manager v2] fix #5106: ui: ceph status: make column wrap the summary text on expand
Date: Mon, 19 Feb 2024 14:59:56 +0100	[thread overview]
Message-ID: <589fa91d-13c1-412d-b991-e3b338f0549d@proxmox.com> (raw)
In-Reply-To: <f4c12650-3426-4d5b-a42c-9bfe753405cf@proxmox.com>

On 2/19/24 14:57, Thomas Lamprecht wrote:
> Am 07/12/2023 um 14:35 schrieb Dominik Csapak:
>> with this the title is now completely visible when the column is
>> expanded, even if it's originally too narrow.
>>
>> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> changes from v1:
>> * wrap the text in the column, instead of duplicating it in the expanded
>>    body
>>
>> thanks @thomas for the suggestion
>>
>>   www/css/ext6-pve.css        |  4 ++++
>>   www/manager6/ceph/Status.js | 16 ++++++++++++++++
>>   2 files changed, 20 insertions(+)
>>
>>
> 
> applied, with Fiona's T-b and the fix for the eslint warning squashed in,
> thanks!
> 
> btw. I first tried `pve-eslint --fix .` inside the (clean) www/manager6
> folder, but that just resulted in a truncated ceph/Status.js file, so while
> eslint seems to correctly get the fix option and finds the issue, writing
> out the updated code to the file seems broken – can you look into that?
> (no pressure though)

i guess you meant me with that ;)
yes i can look into that




  reply	other threads:[~2024-02-19 14:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 13:35 [pve-devel] " Dominik Csapak
2024-02-19 13:28 ` Fiona Ebner
2024-02-19 13:57 ` [pve-devel] applied: " Thomas Lamprecht
2024-02-19 13:59   ` Dominik Csapak [this message]
2024-02-19 14:07     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=589fa91d-13c1-412d-b991-e3b338f0549d@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal