From: Hannes Laimer <h.laimer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server] fix #3588: helper: consider NIC count for config-specific timeout
Date: Thu, 21 Nov 2024 16:16:06 +0100 [thread overview]
Message-ID: <57c8bdb5-c688-44f3-805a-2dabcb1577a6@proxmox.com> (raw)
In-Reply-To: <20241115100037.25177-1-h.laimer@proxmox.com>
sent a v2 [1]
[1]
https://lore.proxmox.com/pve-devel/20241121151335.130711-1-h.laimer@proxmox.com/T/#u
On 11/15/24 11:00, Hannes Laimer wrote:
> There have been some reports about `qm start` timeouts on VMs that have a
> lot of NICs assigned.
> This patch considers the number of NICs when calculating the config-specific
> timeout. Since the increase in start time is linearly related to the number
> of NICs, a constant timeout increment per NIC was chosen.
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> PVE/QemuServer/Helpers.pm | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/PVE/QemuServer/Helpers.pm b/PVE/QemuServer/Helpers.pm
> index 0afb6317..99cb3ab8 100644
> --- a/PVE/QemuServer/Helpers.pm
> +++ b/PVE/QemuServer/Helpers.pm
> @@ -167,6 +167,14 @@ sub config_aware_timeout {
> $timeout = 150;
> }
>
> + # Some testing showed that adding a NIC increased the start time by ~450ms
> + # consistantly across different NIC models, options and already existsing
> + # number of NICs.
> + # So, 10x that to account for any potential system differences seemed
> + # reasonable.
> + my $nic_count = grep { /^net/ } keys %{$config};
> + $timeout += $nic_count * 5;
> +
> return $timeout;
> }
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-21 15:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 10:00 Hannes Laimer
2024-11-21 14:38 ` Fiona Ebner
2024-11-21 15:16 ` Hannes Laimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57c8bdb5-c688-44f3-805a-2dabcb1577a6@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox