public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] aüüöoed:  [PATCH docs] correct outdated info about gui header
Date: Thu, 2 Nov 2023 20:47:04 +0100	[thread overview]
Message-ID: <57c34bc1-8ee9-4cf7-8f3f-eaa5c7607eab@proxmox.com> (raw)
In-Reply-To: <20231102150823.46611-1-d.csapak@proxmox.com>

On 02/11/2023 16:08, Dominik Csapak wrote:
> the header part of the gui did change, by moving the user name into a
> button, which now contains more user specific actions. Update it to be
> correct again.
> 

applied, with some language follow-ups, thanks — keeping such things
up-to-date is important work!

> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  pve-gui.adoc | 18 ++++++++++--------
>  1 file changed, 10 insertions(+), 8 deletions(-)
> 
> diff --git a/pve-gui.adoc b/pve-gui.adoc
> index 9f63a7e..046fb9f 100644
> --- a/pve-gui.adoc
> +++ b/pve-gui.adoc
> @@ -101,21 +101,23 @@ search bar nearside you can search for specific objects (VMs,
>  containers, nodes, ...). This is sometimes faster than selecting an
>  object in the resource tree.
>  
> -To the right of the search bar we see the identity (login name). The
> -gear symbol is a button opening the 'My Settings' dialog. There you
> -can customize some client side user interface setting (reset the saved
> -login name, reset saved layout).
> -
> -The rightmost part of the header contains four buttons:
> +The right part of the header contains four buttons:
>  
>  [horizontal]
> -Help :: Opens a new browser window showing the reference documentation.
> +Documentation :: Opens a new browser window showing the reference documentation.
>  
>  Create&nbsp;VM :: Opens the virtual machine creation wizard.
>  
>  Create&nbsp;CT :: Open the container creation wizard.
>  
> -Logout :: Logout, and show the login dialog again.
> +Identity&nbsp;Menu :: Displays the identity and contains user specific options.

IMO that name is rather odd.. changed to "User Menu"

I connected the following paragraph with the above definition-list entry
by placing a "+" on the empty line, that way they are separate paragraphs
but still indented on the same level, which IMO makes sense for the menu
child entries.

> +
> +The identity menu contains various user specific options, such as the 'My

"various user specific options" is a repetition from the list above, sticks
especially out because it's already a bit superfluous there too, i.e., what
else would the "user menu" contain? ^^

> +Settings' dialog. There you can customize some client side user interface
> +setting (reset the saved login name, reset saved layout).

I reworded to avoid the parenthesis, but they were mostly pre-exsiting,
so just mentioning for the record.

> +
> +It also contains a shortcut to the 'TFA', 'Language' and 'Color Theme'
> +settings, as well as the Logout option.
>  
>  
>  [[gui_my_settings]]





      reply	other threads:[~2023-11-02 19:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 15:08 [pve-devel] " Dominik Csapak
2023-11-02 19:47 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57c34bc1-8ee9-4cf7-8f3f-eaa5c7607eab@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal