From: Stefan Hanreich <s.hanreich@proxmox.com>
To: Stoiko Ivanov <s.ivanov@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [PATCH pve-firewall 1/1] fix #7818: disallow line feeds in firewall comments
Date: Wed, 15 Jul 2026 12:11:38 +0200 [thread overview]
Message-ID: <579330f3-0604-46ba-8eb6-e07b336d741b@proxmox.com> (raw)
In-Reply-To: <20260715114753.69626912@rosa.proxmox.com>
On 7/15/26 11:48 AM, Stoiko Ivanov wrote:
[snip]
>> +sub pve_fw_verify_comment_spec {
>> + my ($comment) = @_;
>> +
>> + if ($comment =~ m/[\n\r]/) {
> suggestion: would restrict this here to printable characters
> and exclude any vertical space:
> https://perldoc.perl.org/perlunicode#%5Cp%7BPrint%7D
> https://perldoc.perl.org/perlunicode#%5Cp%7BVertSpace%7D
>
> as I'd not expect people to use control-chars in their comments
> (of course that's breaking backward-compat a bit more)
Yeah, should've thought of that initially as well - sent a v2 addressing
that.
next prev parent reply other threads:[~2026-07-15 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-15 9:34 [PATCH pve-firewall 1/1] fix #7818: disallow line feeds in firewall comments Stefan Hanreich
2026-07-15 9:48 ` Stoiko Ivanov
2026-07-15 10:11 ` Stefan Hanreich [this message]
2026-07-15 10:11 ` superseded: " Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=579330f3-0604-46ba-8eb6-e07b336d741b@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox