From: Fiona Ebner <f.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH common 1/2] REST environment: warn helpers: use warn instead of printing to stderr
Date: Mon, 5 Feb 2024 14:08:11 +0100 [thread overview]
Message-ID: <575eebca-4756-4fb9-948c-5d310c3872f6@proxmox.com> (raw)
In-Reply-To: <89a5ce7d-0be1-4a5a-8f34-c3365a873bf4@proxmox.com>
Am 05.02.24 um 13:38 schrieb Thomas Lamprecht:
> Am 05/02/2024 um 13:28 schrieb Fiona Ebner:
>> Like this, __WARN__ handlers will still be called. In particular,
>> daemons like pvestatd will set a __WARN__ handler and also log
>> warnings to syslog. The intention behind introducing log_warn() was to
>> make warnings more visible, not less, so fix the semantics to make
>> sure switching from warn to log_warn() does not have this unintended
>> side-effect.
>
> did you saw my reply w.r.t. this [0]?
>
> https://lists.proxmox.com/pipermail/pve-devel/2024-February/061610.html
Yes, but I wanted to make log_warn and warn behave more consistently,
since I wasn't aware that they should be different. I can send a v2 with
using syslog() in log_warn() instead.
prev parent reply other threads:[~2024-02-05 13:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 12:28 Fiona Ebner
2024-02-05 12:28 ` [pve-devel] [RFC common 2/2] REST environment: fork worker: install custom __WARN__ handler Fiona Ebner
2024-02-05 12:39 ` Thomas Lamprecht
2024-02-05 13:08 ` Fiona Ebner
2024-02-05 12:38 ` [pve-devel] [PATCH common 1/2] REST environment: warn helpers: use warn instead of printing to stderr Thomas Lamprecht
2024-02-05 13:08 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=575eebca-4756-4fb9-948c-5d310c3872f6@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox