[pve-devel] applied: [PATCH qemu-server v4] fix 3886: QEMU restore: verify storage allows images before writing

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 24.02.22 11:45, Matthias Heiserer wrote:
> When restoring a backup and the storage the disks would be created on
> doesn't allow 'images', the process errors without cleanup.
> This is the same behaviour we currently have when the storage is
> disabled.
> 
> Adds the Datastore.AllocateSpace check to cloudinit drives.

that belongs in a separate patch, I split that out.

> 
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>

Please pick up T-b/R-b tags from earlier reviews if the patch did not change
substantially in between - thx!

> ---
> Thanks to Fabian!
> Changes from v3:
>  + Restore a line I accidentally deleted
> 
> Changes from v2:
>  + Also check Datastore.AllocateSpace permissions for cloudinit device
>  + Move content type check closer to allocate permission check
> 
> Changes from v1:
>  + Check content type for cloud init drives
>  
>  PVE/QemuServer.pm | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
>

applied, thanks! Followed up with using a closure for the shared checks, not
less lines of code but slightly less noise in the looping over backup config
part.